Move actiont checking from codegen to ast validation. - #659
Open
ratmice wants to merge 6 commits into
Open
Conversation
ratmice
commented
Aug 8, 2026
Collaborator
Author
There was a problem hiding this comment.
There is a similar error here that should probably also be moved in this patch
Collaborator
Author
There was a problem hiding this comment.
Ditto for this error.
Collaborator
Author
ratmice
commented
Aug 9, 2026
| InvalidString, | ||
| NoStartRule, | ||
| UnknownSymbol, | ||
| UnrecognizedDollarVariable, |
Collaborator
Author
There was a problem hiding this comment.
Would UnrecognizedActionVariable be better?
ratmice
commented
Aug 9, 2026
| ) -> Result<(), YaccGrammarError> { | ||
| let kind_requires_actiont = matches!( | ||
| yacc_kind, | ||
| Some(YaccKind::Original(YaccOriginalActionKind::UserAction)) | Some(YaccKind::Grmtools) |
Collaborator
Author
There was a problem hiding this comment.
We could consider making this boolean check a method on YaccKind?
With a different name like YaccKind::requires_actions?
I think it might also simplify a similar check in CTParserBulder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is an attempt to validate actiont earlier,
adding it to
YaccGrammarError.I'm uncertain it's possible to trigger for
YaccKind::GrmtoolsI would imagine you'd get a syntax error before it couldcomplete_and_validate. So I checked that with a manually constructed AST.