Repository navigation
[Feat] Support manual exec with solana 2.0 as destination - #477
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 PabloMansanet, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
CI Test Report✅ 3907/3913 tests passed (996 suites) in 5m 33s SummaryCoverage report |
jadepark-dev
reviewed
Oct 2, 2026
Comment on lines
+250
to
+251
| export async function bufferExecutionInputsIxs( | ||
| connection: Connection, |
There was a problem hiding this comment.
nit: do we also need ctx here to keep the convention?
agusaldasoro
previously approved these changes
Oct 7, 2026
| describe('SolanaChain.buildMessageForDest', () => { | ||
| it('should populate SVMExtraArgsV1 with computeUnits from gasLimit', () => { | ||
| const message = { | ||
| receiver: 'So11111111111111111111111111111111111111112', |
Contributor
There was a problem hiding this comment.
is this receiver value correct?
Collaborator
Author
There was a problem hiding this comment.
It's just a placeholder pubkey, I went with default +1, but I know it reads a bit strangely, can replace with an arbitrary string if it reads better.
|
|
||
| // Accounts of `buffer_execution_inputs` and `close_execution_inputs_buffer`, the last two for | ||
| // their CPI events | ||
| function bufferingAccounts( |
Contributor
There was a problem hiding this comment.
are this accounts for buffering the message or just additional accounts that we need to send among?
Collaborator
Author
There was a problem hiding this comment.
They are buffering only. The comment may not be super clear, the last two accounts are just needed for the buffering instructions to call emit_cpi!
| caller, | ||
| bufferId, | ||
| }) | ||
| unsigned = await unsignedExecuteV2Tx(ctx, caller, instruction, lookupTables, { |
Contributor
There was a problem hiding this comment.
the names generateUnsignedExecuteV2 and unsignedExecuteV2Tx are really similar right? What's the difference?
Collaborator
Author
There was a problem hiding this comment.
Hmmm yeah they're quite similar, generate is the exported entrypoint. The other one just wraps the raw unsigned instruction with some extras i.e. heap frame request, LUT, etc.
I can rename to wrapUnsignedExecuteV2Tx maybe for clarity
PabloMansanet
enabled auto-merge
October 7, 2026 14:46
PabloMansanet
disabled auto-merge
October 7, 2026 14:46
agusaldasoro
previously approved these changes
Oct 8, 2026
andrevmatos
previously approved these changes
Oct 8, 2026
PabloMansanet
dismissed stale reviews from andrevmatos and agusaldasoro
via
October 9, 2026 10:42
a9a65df
jadepark-dev
approved these changes
Oct 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.