Repository navigation
fix: pin shellcheck in .tool-versions for lefthook pre-commit - #1675
Merged
Merged
Conversation
paigeCLL
force-pushed
the
fix/pre-commit-shellcheck-mise
branch
from
September 30, 2026 22:52
3da5972 to
226c433
Compare
erikburt
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shellcheck 0.11.0to.tool-versions.Why
The
shellcheckpre-commit hook (lefthook.yml) invokes the bareshellcheckbinary, but it was never declared as a repo tool in.tool-versions. On fresh checkouts, mise does not install it, so any commit that stages a*.shfile fails with:This surfaced while resolving merge conflicts on #1674 (DX-4948). Pinning it in
.tool-versionsmakes mise install it automatically for everyone, alongside the existingnodejs/pnpmpins.Verified:
mise installpicks up the pin andshellcheck 0.11.0resolves.Notes / follow-ups
actionlintis also invoked by the pre-commit hook but is likewise not declared in.tool-versions— it only worked here because it was installed globally. It could be added the same way if desired.tools/scripts/sync-reusable-workflows.sh(theworkflows:fixhook) usesdeclare -A, which requires bash 4+ and therefore cannot run on macOS's stock bash 3.2 — a separate, pre-existing issue.🤖 Generated with Claude Code