Feat/incognito mode - #201
Open
rishabhjain92 wants to merge 5 commits into
Open
Conversation
Threads an optional incognito boolean (default false) through all three bridge layers to the new incognito support in the native SDKs: - JS: triggerTransaction(transactionId, utmParams, brokerList, incognito) - Android: new trailing incognito param on the @ReactMethod, forwarded to SmallcaseGatewaySdk.triggerTransaction's incognito param - iOS: new trailing incognito param on the RCT_REMAP_METHOD, forwarded to the triggerTransactionFlow(...incognito:completion:) Obj-C overload Additive/backward-compatible - existing callers passing 1-3 args are unaffected. Requires the native SDK dependency pins (android/build.gradle, react-native-smallcase-gateway.podspec) to point at builds containing the incognito support before this compiles - currently still pinned to stable 6.1.1 / 7.2.0, which predate it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds an Incognito Mode section to the README covering the new triggerTransaction(transactionId, utmParams, brokerList, incognito) parameter - what it does, backward compatibility, and known limitations (AutoFill, account-level connection state). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Internal test pins for QA against the incognito-mode branch builds, mirroring the existing dark-theme branch pin pattern: - Android: com.smallcase.gateway:sdk-feat-incognito-mode-c1b21c9:6.1.2-3193-release - iOS: SCGateway-feat-incognito-mode-2d15c7b 7.2.0-28-release Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Previously incognito was a required non-nullable param at the native bridge layer (Boolean in Kotlin, BOOL in Objective-C) - it only felt optional to JS callers because src/SmallcaseGateway.js always computed a default before forwarding. That's inconsistent with utmParams/brokerList, which are genuinely nullable at the bridge, and with the native SDKs themselves where incognito is a real default parameter. Now nullable on both platforms (Boolean? / nullable NSNumber *), defaulting to false when absent, so the bridge methods are robust regardless of whether a caller goes through the JS wrapper. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.