Skip to content

Fix DocBlocks for callable route handlers - #3389

Merged
akrabat merged 2 commits into
slimphp:4.xfrom
odan:4x-route-callable
May 23, 2025
Merged

akrabat merged 2 commits into
slimphp:4.xfrom
odan:4x-route-callable

Conversation

@odan

@odan odan commented May 23, 2025

Copy link
Copy Markdown
Contributor

This PR will fix the DocBlocks for callable route handlers.
I also had to update the dependencies to test it with phpstan and PHP 8.4.

See #3384 and #3379

@coveralls

coveralls commented May 23, 2025 •

Copy link
Copy Markdown

Coverage Status

coverage: 99.522% (-0.001%) from 99.523%
when pulling 727a935 on odan:4x-route-callable
into e4aff28 on slimphp:4.x.

@odan
odan requested a review from akrabat May 23, 2025 15:16

@akrabat akrabat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odan

odan commented May 23, 2025

Copy link
Copy Markdown
Contributor Author

@akrabat The code coverage decreased. Can we still merge this?

@akrabat

akrabat commented May 23, 2025

Copy link
Copy Markdown
Member

@akrabat The code coverage decreased. Can we still merge this?

Yes.

@akrabat
akrabat merged commit ccce102 into slimphp:4.x May 23, 2025
@odan
odan deleted the 4x-route-callable branch May 23, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants