Skip to content

Only render tip to error log if plain text renderer is used - #3321

Merged
akrabat merged 1 commit into
slimphp:4.xfrom
akrabat:3317-do-not-write-tips-message-to-formatted-output
Jun 13, 2024
Merged

akrabat merged 1 commit into
slimphp:4.xfrom
akrabat:3317-do-not-write-tips-message-to-formatted-output

Conversation

@akrabat

@akrabat akrabat commented May 9, 2024

Copy link
Copy Markdown
Member

If the logErrorRenderer is not the plain text renderer then we must not render the tips message as this will break the structured format of the message that's been rendered.

Closes #3317

If the logErrorRenderer is not the plain text renderer then we must not
render the tips message as this will break the structured format of the
message that's been rendered.

Closes slimphp#3317
@akrabat akrabat added this to the 4.14.0 milestone May 9, 2024
@akrabat
akrabat requested review from geggleto and l0gicgate May 9, 2024 19:43
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 99.427%. remained the same
when pulling bb96d39 on akrabat:3317-do-not-write-tips-message-to-formatted-output
into ad92887 on slimphp:4.x.

@akrabat
akrabat merged commit 8388b33 into slimphp:4.x Jun 13, 2024
@akrabat
akrabat deleted the 3317-do-not-write-tips-message-to-formatted-output branch June 13, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using wrong flag to write to error log in ErrorHandler

2 participants