Skip to content

Do not HTML entity encode in PlainTextErrorRenderer - #3319

Merged
akrabat merged 1 commit into
slimphp:4.xfrom
akrabat:3298-do-not-encode-plain-text-errors
May 9, 2024
Merged

akrabat merged 1 commit into
slimphp:4.xfrom
akrabat:3298-do-not-encode-plain-text-errors

Conversation

@akrabat

@akrabat akrabat commented May 1, 2024

Copy link
Copy Markdown
Member

The PlainTextErrorRenderer should not encode exception messages as that's not required for plain text in the same way that it is not required for the JsonErrorRenderer.

Closes #3298

The PlainTextErrorRenderer should not encode exception messages as
that's not required for plain text in the same way that it is not
required for the JsonErrorRenderer.

Closes slimphp#3298
@akrabat akrabat added this to the 4.14.0 milestone May 1, 2024
@akrabat
akrabat requested a review from l0gicgate May 1, 2024 19:42
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 99.429% (+0.002%) from 99.427%
when pulling 9395e43 on akrabat:3298-do-not-encode-plain-text-errors
into 038fd57 on slimphp:4.x.

@geggleto geggleto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akrabat
akrabat merged commit ad92887 into slimphp:4.x May 9, 2024
@akrabat
akrabat deleted the 3298-do-not-encode-plain-text-errors branch May 9, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTML Entity Encoding in PlainTextErrorRenderer

3 participants