Persist routes indexed by name in RouteCollector for improved performance.

[BusterNeece]

In our application, we have what I think is a reasonable number of routes defined (a few dozen), and we're often calling RouteParserInterface::relativeUrlFor and its related functions. Under the hood, these all call RouteCollectorInterface::getNamedRoute, and right now, that's iterating through every single route, checking the name, and returning the result if it finds it.

Individually, these calls aren't a big deal, but they add up fast. If, say, you're returning an API response with several records with several links in each row, this tends to result in a huge number of calls to RouteInterface::getName().

As a result of their exposed methods, the nature of the RouteCollectorInterface and RouteParserInterface means that it isn't possible to implement a lookup table like this in one's own code without reimplementing the entire RouteParserInterface::relativeUrlFor functionality.

However, fortunately that also means that this change can be made at the Slim level without any change to the interface. The logic here is identical to how it functions currently (the first route with a given name is returned by getNamedRoute()).

[akrabat]

Thanks for this! Just a few changes that would be useful.

[BusterNeece]

@akrabat Changes should be incorporated now.

[coveralls]

Coverage decreased (-0.5%) to 99.36% when pulling c0bc6a5 on BusterNeece:4.x into ca629c1 on slimphp:4.x.

[akrabat]

Thanks