Skip to content

Using assertSame to let assert equal be restricted - #3228

Merged
akrabat merged 3 commits into
slimphp:4.xfrom
peter279k:assertion_enhancement
Nov 5, 2022
Merged

Using assertSame to let assert equal be restricted#3228
akrabat merged 3 commits into
slimphp:4.xfrom
peter279k:assertion_enhancement

Conversation

@peter279k

@peter279k peter279k commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

Changed log

  • As title, it should use the assertSame to let assert equals be restricted.

@coveralls

coveralls commented Nov 5, 2022 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0003%) to 99.892% when pulling 3c13502 on peter279k:assertion_enhancement into 3d7ea05 on slimphp:4.x.

@akrabat akrabat added this to the 4.11.0 milestone Nov 5, 2022
@akrabat
akrabat merged commit ca629c1 into slimphp:4.x Nov 5, 2022
@akrabat

akrabat commented Nov 5, 2022

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@flangofas flangofas flangofas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@peter279k @coveralls @akrabat @flangofas