Repository navigation
Handlers types - #3193
Merged
Merged
Handlers types#3193
Conversation
nbayramberdiyev
approved these changes
May 4, 2022
l0gicgate
approved these changes
May 5, 2022
|
Adding type to a base class causes fatal when child classes are not updated accordingly. Should this not have been a major version bump? @l0gicgate |
chriscct7
pushed a commit
to awesomemotive/aioseo-slim-v3-php-8.1
that referenced
this pull request
Sep 3, 2025
Handlers types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some more property type hints! This time for
HandlersA few notes on the changes made to
ErrorHandler:methodproperty was being accessed before init, so I've switched it to be a nullable string with a default of nulllogErrorDetailsanddisplayErrorDetailsproperties were being accessed before init, so I've given them both default values of falseIf there is a more sensible solution for the above, please let me know!