Repository navigation
docs: SK-3168: List flowvault unary samples and new options classes - #448
Open
promptless[bot] wants to merge 1 commit into
Conversation
![promptless[bot]](https://avatars.githubusercontent.com/in/979718?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## himanshupal/SK-3168-flowvault-Java-parity-fix #448 +/- ##
=================================================================================
Coverage 91.39% 91.39%
=================================================================================
Files 197 197
Lines 8126 8126
Branches 1131 1132 +1
=================================================================================
Hits 7427 7427
Misses 449 449
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Why
#447 (SK-3168) adds four unary operations to
flowvault:query,getTokens,uploadFiles, anddeleteFiles, each with a sample. The PR documents them inflowvault/README.md, but two reference spots are still incomplete:getTokens.UploadFilesOptionsandDeleteFilesOptionsalso accept aRequestInterceptor.flowvault/samples/README.mdlists only the bulk samples. It doesn't list any unary sample, including the four new ones.Goal
uploadFiles/UploadFilesOptionsanddeleteFiles/DeleteFilesOptionsto the options-class table inflowvault/README.md.InsertExamplethroughDeleteFilesExample) in the samples README. Also note that the shared response-handling pattern described there applies to the bulk samples.This PR targets the #447 head branch, because
maindoesn't include these operations yet.Testing
VaultControllermethod in the SK-3168 flowvault java parity fix #447 head branch (ead4aeb). Checked the sample descriptions against each sample's Javadoc and code.Trigger Events