Repository navigation
docs: Fix Android SDK README code samples and API names - #200
Open
promptless[bot] wants to merge 1 commit into
Open
promptless[bot] wants to merge 1 commit into
promptless[bot] wants to merge 1 commit into
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open in Promptless
Why
Several code samples and API descriptions in the Android SDK READMEs don't match the SDK source. A developer who copies them gets compile errors or implements the wrong interface.
Goal
skyvault/README.md: replace six calls to the nonexistentSkyflow.initialize(config)withSkyflow.init(config). Fix theTokenProvidermethod name (getBearerToken, notgetAccessToken) and the element-type count (8, not 5).skyvault/README.md: changeCollectOptions(tokens = …)to the real parametertokenin 13 places and fix theadditonalFieldstypo. Both module READMEs: correctCARD_HOLDER_NAMEtoCARDHOLDER_NAME.invokeConnection(), which is deprecated and internal, so apps can't call it.samples/README.md: say that only the flowvault sample falls back to placeholder values whenlocal.propertieskeys are unset.Testing
maincommit. Review comments on this PR link each correction to the source line that supports it.Trigger Events