Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35. The same unused import is also reported by #36 and #37.
Remove the unused
OrderTypeEnumimport fromwebsocket-event.ts. No runtime behavior changes.Verification
npx --no-install tsc --noEmit --incremental false: passed.npm run build: passed.--forceExitfor pre-existing interval handles; it is not a claim that the whole socket suite passes.git diff --check: passed.The broader suite's previously reproduced reconnect/order timing failures are unchanged upstream issues. Credential-dependent playground tests were excluded; no exchange transactions were performed. The import deletion was independently reviewed, and full lint, typecheck and the nine client/Nest tests were rerun successfully.
AI assistance was used for this change and verification. This is one cleanup for overlapping reports, not three distinct implementations.