Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24.
Changes
ListenKeyService.extendListenKey(listenKey, account)using the existing PUT endpoint.BingxExtendListenKeyEndpointthrough the public package entry point. Use direct imports inside the endpoint to avoid a circular import when loading that entry point.Verification
Passed locally:
The focused run passes 18 tests across four suites, including all nine new tests. The tests use synthetic credentials and mocked executors.
Existing baseline failures
I also compared the broader local WebSocket/unit suite against clean upstream
e10420ed2294be869424088f5eb699ecff6e4a82, excluding the credential-dependent exchange playground:timeout 35s npm test -- --runInBand --testPathIgnorePatterns=/playground/OrderTypeEnumimport insrc/bingx/interfaces/websocket-event.ts:1on both revisions. All changed TypeScript files pass lint.Implementation and review used AI assistance; the checks above were actually executed.