feat(bun): upgrade to bun, reduce docker image size by 95%, upgrade docs & ci by waleedlatif1 · Pull Request #369 · simstudioai/sim

waleedlatif1 · 2025-05-18T00:52:53Z

migrate to bun
added envvars to drizzle
upgrade bun devcontainer feature to a valid one
added bun, docker not working
updated envvars, updated to bunder and esnext modules
fixed build, reinstated otel
feat: optimized multi-stage docker images
add coerce for boolean envvar
feat: add docker-compose configuration for local LLM services and remove legacy Dockerfile and entrypoint script
feat: add docker-compose files for local and production environments, and implement GitHub Actions for Docker image build and publish
refactor: remove unused generateStaticParams function from various API routes and maintain dynamic rendering
cleanup

Description

Upgrade to bun, reduce docker image size by 95%, upgrade docs & ci

Type of change

New feature (non-breaking change which adds functionality)
Documentation update
Performance improvement
Code refactoring (no functional changes)

How Has This Been Tested?

Tested manually, ensured everything works.

Checklist:

My code follows the style guidelines of this project
[x]I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added tests that prove my fix is effective or that my feature works
All tests pass locally and in CI (npm test)
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
I have updated version numbers as needed (if needed)
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

My changes do not introduce any new security vulnerabilities
I have considered the security implications of my changes

Additional Information:

In a follow-up PR, we will implement the docker container using this new docker image and make the CLI to publish the new docker image.

…ove legacy Dockerfile and entrypoint script

… and implement GitHub Actions for Docker image build and publish

…I routes and maintain dynamic rendering

vercel · 2025-05-18T00:52:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 18, 2025 7:15am
sim	❌ Failed (Inspect)			May 18, 2025 7:15am

greptile-apps

PR Summary

This PR implements a major migration from Node.js/npm to Bun runtime and package manager, along with significant Docker optimizations. The changes span across the entire codebase with key improvements to environment variable handling and deployment configurations.

Introduced multi-stage Docker builds in docker/app.Dockerfile and docker/db.Dockerfile, reducing image size by 95%
Added new environment variable management system in apps/sim/lib/env.ts using @t3-oss/env-nextjs and Zod for validation
Split Docker Compose configurations into separate files for local, production, and Ollama environments with improved health checks
Removed local storage mode functionality from sync system (apps/sim/stores/sync*.ts) in favor of server-based synchronization
Migrated instrumentation to separate client/server implementations with improved OpenTelemetry and Sentry integration

_{136 file(s) reviewed, 46 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-05-18T00:53:31Z

+ARG USERNAME=bun
 ARG USER_UID=1000
 ARG USER_GID=$USER_UID


logic: No explicit group creation or user addition commands. Could cause permission issues.

Suggested change

ARG USERNAME=bun

ARG USER_UID=1000

ARG USER_GID=$USER_UID

ARG USERNAME=bun

ARG USER_UID=1000

ARG USER_GID=$USER_UID

RUN groupadd --gid $USER_GID $USERNAME \

&& useradd --uid $USER_UID --gid $USER_GID -m $USERNAME

greptile-apps · 2025-05-18T00:53:32Z

+RUN bun completions > /etc/bash_completion.d/bun
+
+# Set up shell environment
+RUN echo "export PATH=$PATH:/home/$USERNAME/.bun/bin" >> /etc/profile


logic: PATH modification uses undefined $PATH which could be empty at this point in the build

greptile-apps · 2025-05-18T00:54:02Z

+LICENSE
+NOTICE
+.prettierrc
+.prettierignore
 README.md
-.devcontainer 
+.gitignore
+.husky
+.github
+.devcontainer
+.env.example
+node_modules


logic: Critical files like .next (build output), .env, and .env.* (environment variables) are no longer excluded. These should remain in .dockerignore to prevent sensitive data leaks and unnecessary files in the build context.

Suggested change

LICENSE

NOTICE

.prettierrc

.prettierignore

README.md

.devcontainer

\ No newline at end of file

.gitignore

.husky

.github

.devcontainer

.env.example

node_modules

LICENSE

NOTICE

.prettierrc

.prettierignore

README.md

.gitignore

.husky

.github

.devcontainer

.env.example

node_modules

.next

.env

.env.*

greptile-apps · 2025-05-18T00:54:03Z

+.github
+.devcontainer
+.env.example
+node_modules


style: Add exclusions for common build artifacts and logs: .next/, build/, dist/, *.log to optimize build context size

greptile-apps · 2025-05-18T00:54:27Z

+  - package-ecosystem: 'bun'
+    directory: '/apps/sim'


logic: Bun is not currently a supported package-ecosystem value for Dependabot. This will likely cause Dependabot to fail. Consider keeping 'npm' as the package-ecosystem since Bun can still use package.json and npm-style dependencies.

Suggested change

- package-ecosystem: 'bun'

directory: '/apps/sim'

- package-ecosystem: 'npm'

directory: '/apps/sim'

greptile-apps · 2025-05-18T01:09:39Z

+
+# Copy only package files needed for migrations
+COPY package.json bun.lock turbo.json ./
+COPY apps/sim/package.json ./apps/sim/db/


logic: Incorrect destination path - should be ./apps/sim/ instead of ./apps/sim/db/ to match the workspace structure

Suggested change

COPY apps/sim/package.json ./apps/sim/db/

COPY apps/sim/package.json ./apps/sim/

greptile-apps · 2025-05-18T01:09:40Z

+RUN bun install --omit dev --ignore-scripts && \
+    bun install --omit dev --ignore-scripts drizzle-kit drizzle-orm postgres next-runtime-env


style: These two bun install commands can be combined into one for better layer caching: bun install --omit dev --ignore-scripts drizzle-kit drizzle-orm postgres next-runtime-env

greptile-apps · 2025-05-18T01:09:40Z

+COPY apps/sim/package.json ./apps/sim/package.json
+COPY apps/sim/lib/env.ts ./apps/sim/lib/env.ts
+
+WORKDIR /app/apps/sim


logic: Missing ENTRYPOINT/CMD to specify what the container should run (e.g. drizzle migrations)

greptile-apps · 2025-05-18T01:09:41Z


 # Install dependencies local to scripts directory
-npm install --save-dev typescript @types/node @types/react ts-node tsx glob
+bun install --save-dev typescript @types/node @types/react ts-node tsx glob


style: Consider adding a check for bun installation before running bun install

Suggested change

bun install --save-dev typescript @types/node @types/react ts-node tsx glob

if ! command -v bun &> /dev/null; then

echo "Error: bun is not installed. Please install bun first."

exit 1

fi

bun install --save-dev typescript @types/node @types/react ts-node tsx glob

greptile-apps · 2025-05-18T01:09:53Z

+    "@t3-oss/env-nextjs": "0.13.4",
+    "@types/bun": "^1.2.12",
    "@vercel/analytics": "^1.5.0",
+    "bun": "^1.2.13",


logic: Including bun package in dependencies may cause issues since it's meant to be a runtime/CLI tool. Consider moving to devDependencies or removing if not needed for compilation.

waleedlatif1 · 2025-05-18T08:03:13Z

merged in #371

waleedlatif1 and others added 12 commits May 17, 2025 17:11

migrate to bun

b4a2d85

added envvars to drizzle

e780fd8

upgrade bun devcontainer feature to a valid one

99e18b8

added bun, docker not working

7837c1e

updated envvars, updated to bunder and esnext modules

f74aadf

fixed build, reinstated otel

730bf83

feat: optimized multi-stage docker images

b1ccc86

add coerce for boolean envvar

df3e9d0

feat: add docker-compose configuration for local LLM services and rem…

db8e2f7

…ove legacy Dockerfile and entrypoint script

feat: add docker-compose files for local and production environments,…

c51b5e1

… and implement GitHub Actions for Docker image build and publish

refactor: remove unused generateStaticParams function from various AP…

f5bdd01

…I routes and maintain dynamic rendering

cleanup

d2ea965

upgraded bun

1ad8140

vercel Bot deployed to Preview – docs May 18, 2025 01:08 View deployment

vercel Bot had a problem deploying to Preview – sim May 18, 2025 01:09 Failure

greptile-apps Bot reviewed May 18, 2025

View reviewed changes

vercel Bot deployed to Preview – docs May 18, 2025 01:11 View deployment

vercel Bot had a problem deploying to Preview – sim May 18, 2025 01:11 Failure

updated ci

37fbb12

waleedlatif1 force-pushed the new-bun branch from ae7d7db to 37fbb12 Compare May 18, 2025 01:16

vercel Bot deployed to Preview – docs May 18, 2025 01:17 View deployment

vercel Bot had a problem deploying to Preview – sim May 18, 2025 01:18 Failure

vercel Bot deployed to Preview – docs May 18, 2025 02:23 View deployment

vercel Bot had a problem deploying to Preview – sim May 18, 2025 02:24 Failure

fixed build

2af6957

waleedlatif1 force-pushed the new-bun branch from 9707ecc to 2af6957 Compare May 18, 2025 07:14

vercel Bot deployed to Preview – docs May 18, 2025 07:15 View deployment

vercel Bot had a problem deploying to Preview – sim May 18, 2025 07:15 Failure

waleedlatif1 closed this May 18, 2025

waleedlatif1 deleted the new-bun branch May 18, 2025 08:03

Navigation Menu

Uh oh!

feat(bun): upgrade to bun, reduce docker image size by 95%, upgrade docs & ci - #369

feat(bun): upgrade to bun, reduce docker image size by 95%, upgrade docs & ci#369
waleedlatif1 wants to merge 15 commits into
mainfrom
new-bun

waleedlatif1 commented May 18, 2025

Uh oh!

vercel Bot commented May 18, 2025 •

edited

Loading

Uh oh!

greptile-apps Bot left a comment

Uh oh!

greptile-apps Bot May 18, 2025

Uh oh!

greptile-apps Bot May 18, 2025

Uh oh!

greptile-apps Bot May 18, 2025

Uh oh!

greptile-apps Bot May 18, 2025

Uh oh!

greptile-apps Bot May 18, 2025

Uh oh!

greptile-apps Bot May 18, 2025

Uh oh!

greptile-apps Bot May 18, 2025

Uh oh!

greptile-apps Bot May 18, 2025

Uh oh!

greptile-apps Bot May 18, 2025

Uh oh!

greptile-apps Bot May 18, 2025

Uh oh!

waleedlatif1 commented May 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	COPY apps/sim/package.json ./apps/sim/db/
	COPY apps/sim/package.json ./apps/sim/

		RUN bun install --omit dev --ignore-scripts && \
		bun install --omit dev --ignore-scripts drizzle-kit drizzle-orm postgres next-runtime-env

Uh oh!

Conversation

waleedlatif1 commented May 18, 2025

Description

Type of change

How Has This Been Tested?

Checklist:

Security Considerations:

Additional Information:

Uh oh!

vercel Bot commented May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps Bot May 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 18, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 18, 2025

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented May 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel Bot commented May 18, 2025 •

edited

Loading