fix(node): use node subprocess explicitly - #2391
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR ensures the isolated-vm worker subprocess uses Node.js explicitly rather than inheriting the parent process's runtime (Bun). Since the application runs with Bun but
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant App as Bun Application
participant IVM as isolated-vm.ts
participant Check as checkNodeAvailable()
participant Worker as Node.js Worker
App->>IVM: executeInIsolatedVM(request)
IVM->>IVM: ensureWorker()
IVM->>Check: checkNodeAvailable()
alt Node.js not found
Check-->>IVM: false
IVM-->>App: Error: Node.js required
else Node.js available
Check-->>IVM: true
IVM->>Worker: spawn('node', [workerPath])
Worker-->>IVM: Ready message
IVM->>Worker: Execute code
Worker-->>IVM: Result
IVM-->>App: Execution result
end
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist