Repository navigation
fix(mcp): accept numeric path params, read-aware unreadable advice, report unsent code-mode calls - #10211
Merged
Conversation
…eport unsent code-mode calls
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] This PR appears safe to merge. SummaryThis PR fixes numeric path values, safer advice for unreadable answers, and code-mode reports of calls that were never sent.
No actionable issues found. Tests were inspected but not run. Reviews (1) · Last reviewed commit: "fix(mcp): accept numeric path params, re..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sim.apiand the call tools accept numeric path params;describe_operationsignatures declare some as numbers (e.g.version: number), and following them returnedINVALID_CALL. Dispatch now stringifies params once withnormalizeStringRecordunreadableMessage) used by both the call tools and code mode: a write is never told to retry, and only a read that came back too large is told to request less. Dispatch now reports just the factrefusedinstead of "may still complete", so an agent can tell which writes may have happenedFixes the review threads on the release PR (#10207) for
code-mode.tsandcatalog.ts, plus the trace issue found testing code mode live on staging.Type of Change
Testing
code-mode.integration.ts(real/api/mcp, Postgres, isolate pool): 11/11 pass. New case: a numeric path param reaches its route (404, notINVALID_CALL). The queued-writes case now asserts that unsent calls are refused and that no more rows exist than calls sentdispatch.test.ts: new case, a write that answers too large is told not to repeat it and never to request lesslib/api/mcpunit tests 47/47;check:utils,check:comment-hygiene,check:explicit-any,check:test-patterns,check:boundaries; pre-push type-checkChecklist
test-auditauthoring gate)