Repository navigation
fix(computer-use): reject impossible app-command dates and name the destination in confirmations - #10210
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] This PR appears safe to merge; no new actionable issues were found. SummaryThis PR rejects impossible app-command dates, matches saved reminder text to its confirmation, and shows destination names instead of ids.
The earlier offset-limit finding is fixed: offsets at 14 hours now require zero minutes. No new actionable issues found. Reviews (2) · Last reviewed commit: "fix(computer-use): read only ASCII digit..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…estination in confirmations - The helper's zoned date-time parser rolled Feb 30, Feb 29 in a common year and hour 24 into other days and accepted offsets like +25:00; zoned values are now checked part by part, while local times keep the strict formatter - Reminders trim their title and notes with the same helpers events use, so the confirmation shows exactly what is saved - The confirmation names the chosen list, calendar or group, read from the helper when it is shown; an id missing from a complete list is refused before the user is asked - Synced the computer-use contract, which now refuses impossible dates at tool validation
…4:00; accept minute-precision zoned times
2c64716 to
1d92305
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
ISO8601DateFormatter) rolled Feb 30, Feb 29 in a common year and hour 24 into other days and accepted offsets like+25:00/+05:99; zoned values are now checked part by part (offset up to ±14:00), local times keep the strict formatter, and date errors name their fieldcreate_remindertrims its title and notes with the same helperscreate_eventuses, so the confirmation's trimmed values are exactly what is savedlist_unavailable, not started) before the user is asked, and past the 200-item read the id itself is showncomputer-use.generated.ts: the contract now refuses impossible dates at tool validation (companion of the mothership PR)Type of Change
Testing
NativeTests.swift: impossible zoned dates, hour 24 and bad offsets rejected; leap day and+05:30parsed; passes in three time zones, fails on the staging helperservice.test.ts: confirmation names the list, calendar and group; unknown id refused before confirming; truncated read falls back to the id (fails on the staging service); 45/45Checklist
test-auditauthoring gate)