Skip to content

fix(computer-use): reject impossible app-command dates and name the destination in confirmations - #10210

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/computer-use-app-command-review
Nov 19, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/computer-use-app-command-review

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The helper's zoned date-time parser (ISO8601DateFormatter) rolled Feb 30, Feb 29 in a common year and hour 24 into other days and accepted offsets like +25:00 / +05:99; zoned values are now checked part by part (offset up to ±14:00), local times keep the strict formatter, and date errors name their field
  • create_reminder trims its title and notes with the same helpers create_event uses, so the confirmation's trimmed values are exactly what is saved
  • The write confirmation names the chosen reminder list, calendar or contact group instead of its id, read from the helper when the confirmation is shown; an id missing from a complete list is refused (list_unavailable, not started) before the user is asked, and past the 200-item read the id itself is shown
  • Synced computer-use.generated.ts: the contract now refuses impossible dates at tool validation (companion of the mothership PR)

Type of Change

  • Bug fix

Testing

  • NativeTests.swift: impossible zoned dates, hour 24 and bad offsets rejected; leap day and +05:30 parsed; passes in three time zones, fails on the staging helper
  • service.test.ts: confirmation names the list, calendar and group; unknown id refused before confirming; truncated read falls back to the id (fails on the staging service); 45/45
  • Desktop type-check clean

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 19, 2026 7:03pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no new actionable issues were found.

Summary

This PR rejects impossible app-command dates, matches saved reminder text to its confirmation, and shows destination names instead of ids.

  • App commands reject dates and times that do not exist.
  • Write confirmations show the chosen destination by name.
  • Saved reminder text follows the same trimming rules as other writes.

The earlier offset-limit finding is fixed: offsets at 14 hours now require zero minutes. No new actionable issues found.

Reviews (2) · Last reviewed commit: "fix(computer-use): read only ASCII digit..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

…estination in confirmations

- The helper's zoned date-time parser rolled Feb 30, Feb 29 in a common year and hour 24 into
  other days and accepted offsets like +25:00; zoned values are now checked part by part, while
  local times keep the strict formatter
- Reminders trim their title and notes with the same helpers events use, so the confirmation
  shows exactly what is saved
- The confirmation names the chosen list, calendar or group, read from the helper when it is
  shown; an id missing from a complete list is refused before the user is asked
- Synced the computer-use contract, which now refuses impossible dates at tool validation
@waleedlatif1
waleedlatif1 force-pushed the fix/computer-use-app-command-review branch from 2c64716 to 1d92305 Compare November 19, 2026 19:03
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit e97cb17 into staging Nov 19, 2026
89 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/computer-use-app-command-review branch November 19, 2026 19:30

This branch was previously deployed

1 inactive deployment
Preview — 1d923050 Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant