Skip to content

fix(cli): preserve permission CSV compatibility and diagnostics - #10208

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/search-permission-csv-review
Nov 19, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/search-permission-csv-review

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Accept padded quoted fields and whitespace-only lines in permission CSV uploads, matching the existing GitLab parser.
  • Retain original staging I/O errors as causes while preserving structured CLI errors.

Type of Change

  • Bug fix

Testing

43 focused CLI tests and CLI type-check passed. Regression cases failed before the fixes. Repository lint, generated-artifact checks, block-registry checks, and all 64 audits passed. Full workspace tests and type-checks run in CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 19, 2026 6:37pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

This PR makes permission CSV uploads accept padded fields and whitespace-only lines, and keeps the original file errors available for debugging.

  • Permission CSV uploads now trim padded fields and skip whitespace-only lines.
  • Permission CSV staging errors now keep the original filesystem failure.

No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(cli): preserve permission CSV compat..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 994babd into staging Nov 19, 2026
82 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-permission-csv-review branch November 19, 2026 19:32

This branch was previously deployed

1 inactive deployment
Preview — 08e72a4a Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant