Repository navigation
fix(integrations): stop the higgsfield and exa tools crashing on missing credentials and array inputs - #10198
Merged
Merged
Conversation
…ing credentials and array inputs
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryExa tools now accept list inputs without crashing, and Higgsfield tools give a clear error when no credential is selected.
Reviews (2) · Last reviewed commit: "fix(integrations): type-safe higgsfield ..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two crashes where a tool threw a raw
TypeErrorinstead of a usable error. The recent Exa and Higgsfield validation PRs (#10179, #10174) did not touch either code path.exa_search,exa_get_contents,exa_find_similar_links):parseCommaListcalled.split(',')on whatever arrived. Block inputs send a comma-separated string, but agent and MCP tool calls often sendurls,ids,includeDomains,excludeDomainsorsubpageTargetas an array, which threwe.split is not a function. The parser now accepts an array of strings as well as a comma-separated string. Any other value reads as unset.higgsfieldAuthHeadersthen called.trim()onundefined.higgsfieldHeadersnow throws aUserFailureasking the user to select a Higgsfield credential.Backward compatible: string inputs produce the same request bodies as before, and a run with a resolved credential sends the same headers. Only inputs that used to crash behave differently. Each regression test was confirmed to fail on the pre-fix code.
Follow-up, not in this PR:
validateRequiredParametersAfterMergeonly checksuser-or-llmparams, so anyoauth.requiredtool can run without a resolved token. Most tools then send an empty token and get a 401 from the vendor. A general guard would change behavior for every credentialed tool, so it is left for a separate decision.Release notes
Exa
Higgsfield