Repository navigation
feat(computer-use): add typed reminder, event and contact app commands behind a desktop capability - #10196
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
7eb7430 to
612b864
Compare
|
@cubic-dev-ai review this PR |
[Critical impact] The reviewed changes appear safe to merge. SummaryAdds confirmed commands for Reminders, Calendar, and Contacts through macOS APIs. The latest change preserves seconds in reminder due times.
Reviews (9) · Last reviewed commit: "fix(computer-use): keep seconds in remin..." · Reviewed by Greptile |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 23 files
Requires human review: Auto-approval blocked because this review re-detected 3 unresolved issues already reported by Cubic.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
Correction to my earlier replies: |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
…-command contract
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 28 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
app_commandmethod that runs allowlisted commands through EventKit, never Apple Events or scripts, so scripting apps stay blocked (fix(computer-use): refuse Script Editor, Automator and Shortcuts, which run shell commands outside the Terminal control #9990). It covers Reminders (list_reminder_lists,create_reminder), Calendar (list_calendars,create_event, with timed or all-day events up to 31 days and an optional alert) and Contacts (list_contact_groups,create_contact_group, which returns an existing group of the same name, andcreate_contact, with up to 5 emails and phones and an optional group). A date-time without an offset is the Mac's local time, as typing it into the app would be. Without the matching access a command fails with*_permission_requiredbefore touching anything. Status reports all three accesses without prompting.user_declined/not_started. Commands skip snapshot handling and the post-action observation.computerUseAppCommandsonly by shells that support it, and only sent when computer use itself is allowed for the chat. The authorize route, transport and client tool executor accept the extended schema. The result message tells the model that a created item exists and must not be repeated.personal-information.calendarsand.addressbookentitlements for the hardened runtime.Paired with mothership#983, which must land first (contract sync). Benchmarks show Reminders, Calendar and Contacts data entry costs about 18 GUI calls per item, and 60 to 130 calls per task.
Benchmark
Paired macOS VM runs (Reminders, Calendar and Contacts data-entry tasks, 2 runs each, same VM image, helper and worker build; the only difference is whether the desktop offers app commands):
The miss read two people's values from the wrong duplicate rows of the source CSV; the commands saved exactly what they were given. Editing an existing contact in the same task still went through the GUI, so mixed tasks keep working.
Type of Change
Testing
service.test.ts: every write command (reminder, event, contact group, contact) asks for confirmation; a declined create never reaches the helper; a confirmed create runs once with no observation; app denial stops before the confirmation; list reads need no confirmation. Desktopipc.test.tsand the desktop typecheck pass.payload.test.ts: app commands are offered only where computer use is allowed. I confirmed this test fails with the guard removed.Checklist
test-auditauthoring gate)Companion: simstudioai/mothership#983