Skip to content

fix(integrations): hide retired hugging face providers, encode posthog ids, and trim zep final ids - #10190

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/validate-release-cleanups
Nov 18, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/validate-release-cleanups

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Release cleanups for Hugging Face, PostHog, Zep and the Desktop settings nav.

  • Hugging Face: the provider list is checked against the official @huggingface/inference client (getProviderHelper). Fal AI and Replicate register no conversational task there, and Hyperbolic, Nebius and SambaNova are not registered at all, so none of them has a chat-completions route. Those five options are now hidden: true. They are not removed, so saved workflows that store one still validate, and the request a saved block sends is unchanged.
  • PostHog: every ID path segment (project, organization, flag, cohort, dashboard, insight, experiment, survey, person, recording, event and property definition) goes through safeUrlPathSegment via a small postHogPathSegment helper. Numeric IDs, UUIDs and the @current alias produce byte-identical URLs to production (@ is kept literal).
  • Zep: when an ID was sent raw as the last part of the URL (Delete thread, Get user), the URL parser trimmed its trailing spaces and control characters. Staging started sending them as %20. Those two call sites trim trailing whitespace again, so they match production. Mid-path IDs are unchanged.
  • Desktop settings nav: the Desktop account-plane entry had the same order as Billing. It now sorts just after Billing, matching the unified settings order. This entry does not exist on production yet.
  • Compatibility: no block, subBlock, operation, tool, param or output id was renamed or removed, no dropdown default changed, and no OAuth scope was added.
  • Firecrawl hosted-key billing on cancel is not changed here; see the note below.

Left for a decision: Firecrawl cancelled runs on the hosted key

A hosted-key Firecrawl crawl, batch scrape, agent or extract cancelled mid-poll returns success: false, and hosted cost is applied only to successful results, so credits Firecrawl already used are not billed (Extract has no cancel endpoint, so its job keeps running). There is no existing mechanism that bills this cleanly:

  • Hosted pricing (applyHostedKeyCostToResult) runs only on successful results, and ToolHostingConfig has no option to bill a failed one.
  • In workflow runs, a failed generic-tool block drops output.cost. Only the Function and Pi handlers attach a trusted cost to the thrown error, and normalizeTrustedExecutionCost needs input/output/total, which the hosted cost shape does not have.
  • recordServiceMeteringFailure only records inside a Copilot service-meter scope. In workflow runs it does nothing.
  • The status bodies of crawl, batch scrape and agent do carry a cumulative creditsUsed (Firecrawl v2 OpenAPI). Extract status carries only tokensUsed.

Billing these runs needs new plumbing in the executor and hosted-key path, so it is left out of this PR.

Release notes

Hugging Face

  • Fal AI, Hyperbolic, Nebius, Replicate and SambaNova no longer appear in the Provider list, because Hugging Face does not route chat completions to them. Blocks that already use one keep their saved setting.

PostHog

  • IDs in request paths are now encoded. An ID containing ?, # or a space reaches the right resource instead of breaking the URL, and an ID that is ., .. or contains / is rejected with a clear error instead of addressing a different endpoint. Numeric IDs, UUIDs and @current send the same request as before.
  • Surrounding spaces on a project or resource ID are now ignored instead of causing a 404.

Zep

  • Delete thread and Get user ignore trailing spaces on the thread or user ID again, as they did before IDs were encoded.

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 18, 2026 11:50pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 56 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

This PR cleans up integration choices, makes PostHog request paths safer, restores Zep’s trailing-space behavior, and fixes the Desktop settings order.

  • PostHog tools keep each ID inside its intended request path.
  • The Hugging Face provider list hides five options without chat routes.
  • Zep tools encode IDs while keeping trailing URL cleanup for final IDs.
  • The Desktop account settings entry now appears after Billing.

No actionable issues found. waleedlatif1 explicitly deferred billing for cancelled hosted-key Firecrawl jobs because it needs new executor and billing support; this PR leaves that behavior unchanged.

Reviews (1) · Last reviewed commit: "fix(integrations): hide retired hugging ..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 8e2ed5e into staging Nov 18, 2026
64 of 65 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/validate-release-cleanups branch November 18, 2026 23:46

This branch was successfully deployed

1 active deployment
Preview — 8b1001f3 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant