Repository navigation
fix(integrations): keep saved output references valid and encode firecrawl job ids - #10187
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Critical impact] The PR appears safe to merge; no new blocking issues were found. SummaryThis PR preserves saved output references, hardens Firecrawl polling, adds Kalshi subaccount support, and restores how several integrations treat tabs and newlines in IDs.
No new actionable issues found. Reviews (6) · Last reviewed commit: "fix(integrations): strip url control cha..." · Reviewed by Greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
9e0cbdd to
5f8335b
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 18 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…control characters like the parser
01b1998 to
c3299ab
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 21 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Release hardening and compatibility follow-ups to #10186:
split(/[?#]/, 1)[0]instead of the/[?#].*$/replace, which static analysis can flag as a polynomial regex. Same result for real IDs./undefineduntil the time limit.resultsas strings, Get Consentvendorsas a list of strings) made references that validated in production, such as<tavily.results[0].url>and<ketch.vendors.someVendor>, fail the run with an invalid-field error instead of resolving empty. Their item nodes are now markedopen, the existing schema marker that accepts any sub-path, so every reference that validated before still does while the accurate shapes stay documented.openis added to the tool output types; the executor already honors it. It is an internal reference-validation hint, so the v2 catalog projection strips it at every depth and the public contract is unchanged.subaccountparam, sent as thesubaccountquery param that Kalshi's spec gives CancelOrderV2 and AmendOrderV2. Without it, an order placed on a numbered subaccount through Create Order V2 could not be cancelled or amended. The order read that precedes a cancel without a ticker or an amend without count and price sends no subaccount, because GetOrder takes none. The signature still covers the path only. The block has no subaccount field for create, so this is a tool param only (agents and API callers).stripTabsAndNewlinesoption ofsafeUrlPathSegmentremoves tabs, carriage returns and newlines before encoding, as the URL parser removed them from the raw URL. Only those call sites set it; callers that already encoded the ID in production (Elasticsearch, Qdrant search) keep the exact ID. An ID likecoll\nfrom an LLM output resolves tocollagain instead of a 404 oncoll%0A. Spaces are still encoded, and blank and dot-segment values are still rejected (including after the removal).Backward compatible: the only new param is Kalshi's optional
subaccount, and leaving it empty sends exactly the request sent before. Other request shapes are unchanged, and every output reference that validated in production still validates. A test runsisPathInSchemaagainst the real Tavily Map and Ketch Get Consent outputs with the production-era paths; it fails on current staging.Release notes
Qdrant, Zep and Pinecone
Kalshi
Tavily
results[0].url) keep running instead of failing on an invalid reference.Ketch
vendorskeep running instead of failing on an invalid reference.