Repository navigation
test(desktop): stub the computer use availability hook in the prevent-sleep tests - #10182
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] This test-only change appears safe to merge. SummaryUpdates the desktop prevent-sleep tests to stub the Computer Use availability hook used by the settings page.
No actionable issues found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "test(desktop): stub the computer use ava..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
desktop.test.tsxrenders the whole Desktop page, whose Computer Use section now readsuseComputerUseAvailability(React Query) instead ofuseUserPermissionConfig. The test still mocked the old hook, so its two prevent-sleep cases throwNo QueryClient seton stagingcomputer-use.test.tsxwith a real QueryClient)Type of Change
Testing
desktop.test.tsxandcomputer-use.test.tsxpass (8 tests); the same two cases fail on current staging in CI (checks / test (2/2)on fix(computer-use): show computer use controls on organization Desktop settings #10176)Checklist