Repository navigation
fix(integrations): validate firecrawl, context.dev, apify, bright data, browser use, reducto, pulse and extend - #10180
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryThis PR fixes request options, document results, and cancellation across the scraping and document integrations.
No new actionable issues found. The earlier shared-mock and optional-job-ID findings are addressed. Reviews (6) · Last reviewed commit: "fix(firecrawl): cancel only a job Firecr..." · Reviewed by Greptile |
There was a problem hiding this comment.
1 issue found across 53 files
Confidence score: 4/5
- In
crawl.ts, cancellation duringinterruptibleSleepcan still allow the next Firecrawl poll to start. Check the signal after the sleep in all four polling loops.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/tools/firecrawl/crawl.ts">
<violation number="1" location="apps/sim/tools/firecrawl/crawl.ts:293">
P2: `interruptibleSleep` resolves early when cancelled, but this loop does not re-check the signal before starting the next poll. Add `signal?.throwIfAborted()` immediately after the sleep in all four Firecrawl polling loops.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
1580947 to
96afe2d
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
96afe2d to
7b3f1b1
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
a62a6fa to
8aaf6e4
Compare
8aaf6e4 to
8cadcce
Compare
8cadcce to
543b648
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 56 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
…a, browser use, reducto, pulse and extend
…s, cap Pulse downloads
543b648 to
bdad368
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 56 files
You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Turn on auto-fix | Re-trigger cubic
Summary
Validates the Firecrawl, Context.dev, Apify, Bright Data, TinyFish, Stagehand, Browser Use, Reducto, Pulse and Extend integrations against each vendor's official API spec (Firecrawl v2, Context.dev, Apify, Browser Use v2, Reducto and TinyFish OpenAPI specs, the Pulse and Extend API references, the Bright Data Scraper API reference, and the Stagehand SDK types), and fixes what was wrong.
MAX_DURABLE_LARGE_VALUE_BYTES), so no result that completed before fails now. Pulse's large-result download is capped at the 10 MiB internal-tool response limit that already applied to it.firecrawl_enrichandapps/sim/enrichments/are out of scope and untouched.proxy_config.type: "tetra", which the current spec does not list (proxy_configisadditionalProperties: false). Every unauthenticated probe stops at the API key check, so the server's behavior is unknown./brand/transaction_identifier) is no longer in Context.dev's spec, so it still sendstimeoutMS.creditsUsed, while the spec documents onlytokensUsedfor extract jobs. Hosted-key billing for Extract depends on it.nextwould put the whole result in memory. The Crawl Status and Batch Scrape Status operations still returnnext.Release notes
Firecrawl
rawHtml,summary,linksandscreenshotwhen you request those formats. Before, only markdown, HTML and metadata came back.nextfor later pages.Context.dev
timeoutOpts.milliseconds. Before, Extract and Search failed when a timeout was set, and the other operations ignored it.Apify
Bright Data
.,.., or an ID containing/, with a clear error. Before, the request went to the wrong URL.Browser Use
Reducto
1, 5parsed (and billed) pages 1 through 5..trim is not a function.Pulse
extraction_idoutput, for use with Pulse's split and schema steps..trim is not a function.Extend
CORRUPT_FILE). Before, the block succeeded with no content.