Repository navigation
fix(integrations): validate clerk, crowdstrike, infisical, ketch, onepassword, persona, rootly - #10171
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 96 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The reviewed changes appear safe to merge. SummaryThis PR fixes integration requests, returned data, and editor defaults across seven services.
No new actionable issues were found. The earlier approval-mapper type mismatch is fixed. waleedlatif1 explicitly leaves Clerk API version pinning and 1Password secure-note text for a product decision; unverified vendor behavior stays unchanged. Reviews (4) · Last reviewed commit: "fix(integrations): coerce rootly path id..." · Reviewed by Greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
cb04c55 to
85e0bb7
Compare
85e0bb7 to
d5f1430
Compare
d5f1430 to
27d7e53
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 98 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
27d7e53 to
8d254ca
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
8d254ca to
87dfc2a
Compare
…password, persona, rootly
… narrow the ketch test body
…nknown ketch consent values
…otly title with detail, decrypt 1password vault details
87dfc2a to
f0b0800
Compare
Summary
Validates the CrowdStrike, Rootly, Tailscale, Infisical, 1Password, Vanta, Ketch, Clerk, Persona and Checkr integrations against each vendor's official API spec, and fixes what was wrong.
ketch-web-apiSDK plus unauthenticated probes for Ketch; and@1password/sdktypes for 1Password service accounts. Claims that could not be verified were left unchanged.Clerk-API-Versionheader. Newer BAPI versions moved user and organization metadata out of thePATCHbodies, so pinning a version would change what Update User/Organization accept.detection_suppress/detection_unsuppresshost actions.{data:{}}body is accepted on alert acknowledge/resolve/escalate.Release notes
Persona
address-country-codefor watchlist,country-codefor adverse media and politically exposed person reports. Before, the two were swapped, so the country filter was silently ignored.Ketch
"allowed": "granted"(the value in Sim's own example) was saved by Ketch as denied, because Ketch only accepts"true"/"false".granted/denied(any case) and booleans are now converted, so saved workflows that sendgrantednow record the consent they intended. Any other value is sent unchanged, as before.vendorsoutput of Get Consent is described as a list of vendor IDs, matching what Ketch returns.Infisical
approvaloutput. Before, the change request's ID and timestamps were reported as the secret's..or..is now refused instead of being sent to a different API path.Clerk
./..are now rejected instead of reaching a different Clerk endpoint. Valid IDs are unaffected.CrowdStrike
1Password
USER_CREATED). Vaults are listed withdecryptDetailsso the description is available.Rootly
Testing
check:tool-metadata,check:docs,check:integration-catalog,check:mapper-operation,check:utils,check:explicit-any,check:tool-param-reachability,check:tool-request-boundary,check:comment-hygiene,check:bare-icons,check:icon-path-precisionandcheck-canvas-sentencesfor every block locally. CI runs type-check and the full suite.