Repository navigation
fix(integrations): validate agentmail - #10169
Merged
Merged
Conversation
Encode AgentMail inbox, thread, draft and message IDs as single path segments. Message IDs are RFC 5322 Message-IDs, which may contain /, #, ? or %, so the raw interpolation could address the wrong resource.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryAgentMail requests now encode resource IDs before adding them to URLs and reject dot-only IDs. The latest revision replaces test-only type casts with a typed helper without changing the checks.
No actionable issues found. Reviews (2) · Last reviewed commit: "fix(integrations): type the agentmail pa..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validates the Jotform, Plane, Rocketlane, ManageEngine ServiceDesk Plus, Windchill, RevenueCat, Sportmonks (core, football, motorsport, odds) and AgentMail integrations against each vendor's official API docs, and fixes the one real problem found.
/,#,?or%addressed the wrong resource. This matches how AgentMail's own SDK encodes path parameters. Requests for ordinary IDs are unchanged apart from@being sent as%40, which the API decodes.permanentparameter, but the API does have a trash state, so the old "move to trash" behavior can't be ruled out without live credentials.Release notes
AgentMail
/,#,?or%. Before, these IDs could reach the wrong URL and fail..or..is now rejected with a clear error instead of addressing a different endpoint.