Skip to content

fix(integrations): validate agentmail - #10169

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/validate-ops-apps
Nov 18, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/validate-ops-apps

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

Validates the Jotform, Plane, Rocketlane, ManageEngine ServiceDesk Plus, Windchill, RevenueCat, Sportmonks (core, football, motorsport, odds) and AgentMail integrations against each vendor's official API docs, and fixes the one real problem found.

  • Endpoints, methods, params, request bodies, auth headers, pagination and response parsing were checked against each vendor's spec: RevenueCat's v1 OpenAPI, AgentMail's OpenAPI, Rocketlane's ReadMe OpenAPI fragments (every path, query key and body key), Plane's v2 reference (all 67 operations), and the Sportmonks v3 endpoint pages (all 210 tool URLs). ManageEngine, Jotform and Windchill were spot-checked against their reference pages. Claims that could not be verified were left unchanged.
  • Validated with no change needed: Jotform, Plane, Rocketlane, ManageEngine ServiceDesk Plus, Windchill, RevenueCat, Sportmonks.
  • AgentMail: inbox, thread, draft and message IDs are now encoded as single path segments. Before, they were put into the URL raw, so an RFC 5322 Message-ID containing /, #, ? or % addressed the wrong resource. This matches how AgentMail's own SDK encodes path parameters. Requests for ordinary IDs are unchanged apart from @ being sent as %40, which the API decodes.
  • No block, subBlock, operation, tool, param or output id was renamed or removed, and no OAuth scope was added. A regression test covers the encoding and fails on the old code.
  • Left unchanged and unverified: AgentMail's Delete Thread "Permanent Delete" option. AgentMail's current docs say thread deletion is always permanent and do not list a permanent parameter, but the API does have a trash state, so the old "move to trash" behavior can't be ruled out without live credentials.

Release notes

AgentMail

  • Get, reply to, forward and update message now work for messages whose ID contains /, #, ? or %. Before, these IDs could reach the wrong URL and fail.
  • An ID of . or .. is now rejected with a clear error instead of addressing a different endpoint.

Encode AgentMail inbox, thread, draft and message IDs as single path
segments. Message IDs are RFC 5322 Message-IDs, which may contain /, #,
? or %, so the raw interpolation could address the wrong resource.
@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 6:31pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 20 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

AgentMail requests now encode resource IDs before adding them to URLs and reject dot-only IDs. The latest revision replaces test-only type casts with a typed helper without changing the checks.

  • AgentMail IDs now stay inside their intended URL path segments.

No actionable issues found.

Reviews (2) · Last reviewed commit: "fix(integrations): type the agentmail pa..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 20 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit e85d2f2 into staging Nov 18, 2026
81 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/validate-ops-apps branch November 18, 2026 20:09

This branch was previously deployed

1 inactive deployment
Preview — 32d7797c Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant