Skip to content

fix(pii): describe the mask client's retry budget the way it actually behaves - #10156

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/pii-retry-comment
Nov 18, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/pii-retry-comment

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Reword the MAX_CHUNK_ATTEMPTS TSDoc to match the retry policy: timeouts are retried as transient congestion, a 500 from one chunk's own input is what the small budget guards against, and an outage (502/503/504) that outlasts the ~1.5s backoff falls to the fail-safe, which also scrubs chunks not yet sent
  • Comment only, no behavior change

Type of Change

  • Documentation

Testing

biome, check:comment-hygiene

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 18, 2026 5:24pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This comment-only change appears safe to merge.

Summary

Updates the retry-budget comment to match the existing PII masking policy. No runtime behavior changes.

  • The masking comment explains which failures get retried and when the fail-safe takes over.

No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(pii): describe the mask client's ret..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/lib/guardrails/mask-client.ts Resolved
@waleedlatif1
waleedlatif1 merged commit 6dd1d12 into staging Nov 18, 2026
80 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/pii-retry-comment branch November 18, 2026 18:07

This branch was previously deployed

1 inactive deployment
Preview — 6d8b79cc Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant