Repository navigation
fix(pii): describe the mask client's retry budget the way it actually behaves - #10156
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] This comment-only change appears safe to merge. SummaryUpdates the retry-budget comment to match the existing PII masking policy. No runtime behavior changes.
No actionable issues found. Reviews (1) · Last reviewed commit: "fix(pii): describe the mask client's ret..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
waleedlatif1
force-pushed
the
fix/pii-retry-comment
branch
from
November 18, 2026 17:24
76a72cd to
6d8b79c
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_CHUNK_ATTEMPTSTSDoc to match the retry policy: timeouts are retried as transient congestion, a 500 from one chunk's own input is what the small budget guards against, and an outage (502/503/504) that outlasts the ~1.5s backoff falls to the fail-safe, which also scrubs chunks not yet sentType of Change
Testing
biome,
check:comment-hygieneChecklist
test-auditauthoring gate)