Skip to content

feat: update ConsumersService to check for queue prefetch changes in … - #34

Merged
AhmadRAbuhussein merged 1 commit into
mainfrom
muhannad/fix-prefetch-and-assembly
Apr 9, 2026
Merged

feat: update ConsumersService to check for queue prefetch changes in …#34
AhmadRAbuhussein merged 1 commit into
mainfrom
muhannad/fix-prefetch-and-assembly

Conversation

@mmalkhatib

@mmalkhatib mmalkhatib commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

…consumer configuration

Summary by CodeRabbit

  • Chores

    • Updated assembly version to 8.0.0.0 across core libraries.
    • Updated primitive types dependency to version 8.1.3.
  • Bug Fixes

    • Improved consumer refresh detection to properly identify queue prefetch setting changes and apply updates accordingly.

@coderabbitai

coderabbitai Bot commented Apr 9, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 136eaf41-a98d-4516-abd3-bf10db6d6108

📥 Commits

Reviewing files that changed from the base of the PR and between 20104c1 and 76ec750.

📒 Files selected for processing (3)
  • SW.Bus.RabbitMqExtensions/SW.Bus.RabbitMqExtensions.csproj
  • SW.Bus/ConsumersService.cs
  • SW.Bus/SW.Bus.csproj

📝 Walkthrough

Walkthrough

The PR updates assembly version metadata in two project files and adjusts consumer restart logic in ConsumersService to trigger on QueuePrefetch changes instead of ConsumerArgs dictionary equality. It also bumps the SimplyWorks.PrimitiveTypes NuGet dependency from 8.1.2 to 8.1.3.

Changes

Cohort / File(s) Summary
Assembly Version Updates
SW.Bus.RabbitMqExtensions/SW.Bus.RabbitMqExtensions.csproj, SW.Bus/SW.Bus.csproj
Added explicit <AssemblyVersion>8.0.0.0</AssemblyVersion> metadata to both project files.
NuGet Dependency Update
SW.Bus.RabbitMqExtensions/SW.Bus.RabbitMqExtensions.csproj
Updated SimplyWorks.PrimitiveTypes from 8.1.2 to 8.1.3.
Consumer Restart Logic
SW.Bus/ConsumersService.cs
Modified RefreshConsumers() to trigger consumer restart on QueuePrefetch changes (prefetchChanged) instead of ConsumerArgs dictionary equality (argsChanged). The DictionariesEqual() function is now unused.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • samerzughul

Poem

🐰 Assembly versions align with grace,
PrefetchQueues now set the pace,
Dependencies refresh anew,
Consumer restarts, oh so true!
A rabbit's hop through RabbitMQ. 🐇

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch muhannad/fix-prefetch-and-assembly

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AhmadRAbuhussein
AhmadRAbuhussein merged commit e8bb931 into main Apr 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants