Skip to content

fix: update native adapter property validation to check for optional … #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AhmadRAbuhussein merged 1 commit into from
Jun 4, 2026
Merged

fix: update native adapter property validation to check for optional … #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SW.Bitween.Api/Resources/Subscriptions/SaveMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ public Validate(NativeAdapterDiscoveryService nativeAdapterDiscovery, IServicePr

if (mapperId.StartsWith(NativeAdapterDiscoveryService.NativePrefix, StringComparison.OrdinalIgnoreCase))
{
var properties = nativeAdapterDiscovery.GetExpectedStartupValues(mapperId);
mustProps = properties.Where(p => p.Value.EndsWith(" *")).Select(p => p.Key);
var properties = nativeAdapterDiscovery.GetStartupValues(mapperId);
mustProps = properties.Where(p => !p.Value.Optional).Select(p => p.Key);
}
else
{
Expand Down
12 changes: 6 additions & 6 deletions SW.Bitween.Api/Resources/Subscriptions/Update.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ public Validate(BitweenDbContext dbContext, IHttpContextAccessor httpContextAcce
// Check if it's a native adapter
if (mapperId.StartsWith(NativeAdapterDiscoveryService.NativePrefix, StringComparison.OrdinalIgnoreCase))
{
var properties = nativeAdapterDiscovery.GetExpectedStartupValues(mapperId);
mustProps = properties.Where(p => p.Value.EndsWith(" *")).Select(p => p.Key);
var properties = nativeAdapterDiscovery.GetStartupValues(mapperId);
mustProps = properties.Where(p => !p.Value.Optional).Select(p => p.Key);
}
else
{
Expand Down Expand Up @@ -174,8 +174,8 @@ public Validate(BitweenDbContext dbContext, IHttpContextAccessor httpContextAcce
// Check if it's a native adapter
if (handlerId.StartsWith(NativeAdapterDiscoveryService.NativePrefix, StringComparison.OrdinalIgnoreCase))
{
var properties = nativeAdapterDiscovery.GetExpectedStartupValues(handlerId);
mustProps = properties.Where(p => p.Value.EndsWith(" *")).Select(p => p.Key);
var properties = nativeAdapterDiscovery.GetStartupValues(handlerId);
mustProps = properties.Where(p => !p.Value.Optional).Select(p => p.Key);
}
else
{
Expand Down Expand Up @@ -219,8 +219,8 @@ public Validate(BitweenDbContext dbContext, IHttpContextAccessor httpContextAcce
// Check if it's a native adapter
if (model.ReceiverId.StartsWith(NativeAdapterDiscoveryService.NativePrefix, StringComparison.OrdinalIgnoreCase))
{
var properties = nativeAdapterDiscovery.GetExpectedStartupValues(model.ReceiverId);
mustProps = properties.Where(p => p.Value.EndsWith(" *")).Select(p => p.Key);
var properties = nativeAdapterDiscovery.GetStartupValues(model.ReceiverId);
mustProps = properties.Where(p => !p.Value.Optional).Select(p => p.Key);
}
else
{
Expand Down