Skip to content

Refactor Metadata class to include NativeAdapterDiscoveryService and … - #134

Merged
AhmadRAbuhussein merged 1 commit into
releases/r8.0from
fix-metadata-500-issue
Apr 2, 2026
Merged

Refactor Metadata class to include NativeAdapterDiscoveryService and …#134
AhmadRAbuhussein merged 1 commit into
releases/r8.0from
fix-metadata-500-issue

Conversation

@hamzahalq

@hamzahalq hamzahalq commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

…improve key handling

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced metadata resolution for URL-encoded keys
    • Improved native adapter discovery handling

@coderabbitai

coderabbitai Bot commented Apr 2, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c2c067d6-e767-4577-809d-602eb77674f0

📥 Commits

Reviewing files that changed from the base of the PR and between fa49f1e and 5618c82.

📒 Files selected for processing (1)
  • SW.Bitween.Api/Resources/Adapters/Metadata.cs

📝 Walkthrough

Walkthrough

The Metadata handler implementation was enhanced to URL-decode incoming request keys and conditionally bypass cloud metadata queries when keys correspond to native adapters. A new NativeAdapterDiscoveryService dependency was injected to support this native adapter detection logic.

Changes

Cohort / File(s) Summary
Metadata Handler Update
SW.Bitween.Api/Resources/Adapters/Metadata.cs
Added URL decoding via Uri.UnescapeDataString, introduced early return for native adapter prefixes (case-insensitive check), updated metadata lookup to use decoded key, and injected new NativeAdapterDiscoveryService dependency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 URLs once twisted, now unbound with care,
The rabbit decodes, making pathways fair,
Native adapters skip the cloud above,
A simpler dance—efficiency and love! 🌿

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-metadata-500-issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AhmadRAbuhussein
AhmadRAbuhussein merged commit 3c66bc7 into releases/r8.0 Apr 2, 2026
1 of 4 checks passed
@MusaMisto
MusaMisto deleted the fix-metadata-500-issue branch July 2, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants