Add shell mode - #164
Merged
Merged
Add shell mode#164
Conversation
Shell scripts pin go tools and docker images in variables the same way
Makefiles do, e.g. `TOOL="${TOOL:-example.com/tool@v1.2.3}"`. The new
`shell` mode reads `*.sh` assignments through make mode's parsers and
rewriter, adding only shell syntax: declaration prefixes, arrays, a
trailing `;` and `${VAR:-default}` defaults.
Values containing `$` are now skipped in both modes because they cannot
be resolved, and prewarming now matches the values themselves instead of
`go install`/`docker` keywords that assignments usually lack.
Co-Authored-By: Claude (Opus 5.5) <noreply@anthropic.com>
Spreading base() into an object literal inferred a type that references `Override` from the `updates` devDependency, which the declaration build cannot name (TS2883). Co-Authored-By: Claude (Opus 5.5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell scripts pin go tools and docker images in variables just like Makefiles, e.g.
TOOL="${TOOL:-example.com/tool@v1.2.3}". This adds ashellmode for*.shthat reuses make mode's parsing and rewriting, with only shell syntax on top: declaration prefixes, arrays, a trailing;and${VAR:-default}defaults.Values containing
$are now skipped in both modes, and a TS2883 in the declaration build is fixed.Written by Claude.