Skip to content

return original value if sub didn't match any pattern - #30

Open
Janim007 wants to merge 1 commit into
sileht:masterfrom
Janim007:fix/return-original-value-on-sub
Open

Janim007 wants to merge 1 commit into
sileht:masterfrom
Janim007:fix/return-original-value-on-sub

Conversation

@Janim007

@Janim007 Janim007 commented Aug 6, 2021

Copy link
Copy Markdown

python sub method always return the original value even if there was no match and replacement.
to be consistent with python, this PR propose to remove checking if value hasn't changed and return the original value as it as.
current behavior:

>>> re.sub(r'foo', 'bar', 'github')
''

expected behavior:

>>> re.sub(r'foo', 'bar', 'github')
'github'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant