Repository navigation
Adding "SignBLEU: Automatic Evaluation of Multi-channel Sign Language Translation" and some eval metrics discussion - #77
Merged
AmitMY merged 23 commits intoJun 21, 2024
Conversation
Contributor
Author
|
All right, I think we're about ready for review: https://chatgpt.com/share/2a913f6c-e344-4a00-86ab-357bbae6ec8d is the conversation with ChatGPT and revisions of the summary. Took some, discarded others Questions:
|
cleong110
marked this pull request as ready for review
June 14, 2024 20:23
AmitMY
requested changes
Jun 15, 2024
AmitMY
requested changes
Jun 18, 2024
AmitMY
requested changes
Jun 19, 2024
Contributor
Author
|
Added some more detail on pose output metrics, and some citations for APE |
AmitMY
requested changes
Jun 20, 2024
| Naively, works in this domain have used metrics such as mean squared error (MSE) or Average Position Error (APE) for pose outputs [ahuja2019Language2PoseNaturalLanguage;ghosh2021SynthesisCompositionalAnimations;petrovich2022TEMOSGeneratingDiverse]. | ||
| However, these metrics have significant limitations for Sign Language Production. | ||
|
|
||
| For example, MSE and APE do not account for variations in sequence length, for cases where where the same sign might take different amounts of time to produce. |
Contributor
There was a problem hiding this comment.
where where
"different amounts of time" sounds strange to me
Contributor
Author
There was a problem hiding this comment.
How about:
For example, MSE and APE do not account for variations in sequence length.
The same sign may not always take exactly the same amount of time to produce.
Or various options here: https://chatgpt.com/share/e4e5cde3-fccf-4e40-ab2f-5b210db6cf6f
AmitMY
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleong110#21 details and checklist