Skip to content

Fix race condition in subjects - #57

Merged
twittemb merged 1 commit into
sideeffect-io:mainfrom
ERussel:fix/race-condition
Oct 3, 2026
Merged

twittemb merged 1 commit into
sideeffect-io:mainfrom
ERussel:fix/race-condition

Conversation

@ERussel

@ERussel ERussel commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Description

The PR addresses race condition inside subject that could lead to a sent value loss during setup.

Closes #56

Checklist

  • this PR is based on the main branch and is up-to-date, if not please rebase your branch on the top of main
  • the commits inside this PR have explicit commit messages
  • unit tests cover the new feature or the bug fix
  • the feature is documented in the README.md if it makes sense
  • the CHANGELOG is up-to-date

@ERussel ERussel changed the title fix race condition in subjects Fix race condition in subjects Sep 28, 2026
@ERussel

ERussel commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

Looks like a duplicate of #40 but solves broader issue and confirms it with tests first

@twittemb twittemb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] AsyncCurrentValueSubject may miss values when a consumer is added concurrently with send

2 participants