Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

Option not to install CLI locally — use globally installed #42

Description

@mrdimidium

The main volume is @shower/cli. We can add the ability to use globally installed @shower/cli from the presentation, and locally put only theme/core and the like.

Originally posted by @nikolay-govorov in shower/shower#349 (comment)

Activity

  1. added
    featureNew feature or request
    planThis task is a linear part of the development planned for development.
    on May 3, 2019
  2. mrdimidium commented on May 12, 2019

    @mrdimidium
    Author

    Propose a such API: add in the command create the item «Install the CLI locally?».
    If we find globally installed CLI suggest false by default otherwise suggest true.

    @pepelsbey, what are you think?

  3. pepelsbey commented on May 12, 2019

    @pepelsbey
    Contributor

    Sounds… complicated. Maybe we shouldn’t have bundled CLI into Shower in the first place?

    We can make it global only again and suggest installing CLI instead of providing npm scripts.

  4. mrdimidium commented on May 12, 2019

    @mrdimidium
    Author

    That's possible. On the other hand, what if you still want to use the local version? How to be if the global version is not installed (for example, when the repository was tilted by another person, or to a new one)? There may also be problems with different versions of the CLI and library. For example, after changing the shower-ribbon and @shower/ribbon, a new CLI can not get the old presentation.

    The locally installed CLI works perfectly simply and reliably.

  5. mrdimidium commented on May 12, 2019

    @mrdimidium
    Author

    Fundamentally with the advent of CLI nothing has changed - before the project was gulpfile and its dependencies, and now the CLI and its dependencies.

    In fact, and now you can manually remove it from package.json write about @shower/cli, and use globally installed. This will work.

  6. mrdimidium commented on May 15, 2019

    @mrdimidium
    Author

    @pepelsbey, what are you think?

  7. pepelsbey commented on May 16, 2019

    @pepelsbey
    Contributor

    I think that the whole Chromium (Puppeteer) for every Shower presentation is way too much. 84.5 Mb to download and 199 Mb on disk just to print your presentation to PDF (which you may never use) is clearly not the best thing to have.

    I’m talking about defaults here, not the option to remove something later, which no one would ever use. No, seriously: let’s make Shower as light as possible and suggest installing CLI tool globally for everyone who would like to use prepare, archive, print, etc.

  8. andriyor commented on Nov 27, 2019

    @andriyor
    Contributor

    I think that the best solution for reducing disk space usage would be using puppeteer-core with chrome-launcher. And if the user provides PUPPETEER_EXECUTABLE_PATH use that path, otherwise use path that provide chrome-launcher.
    If you agree with that, I can make PR

  9. pepelsbey commented on Nov 27, 2019

    @pepelsbey
    Contributor

    @nikolay-govorov what do you think?

  10. mrdimidium commented on Nov 29, 2019

    @mrdimidium
    Author

    I apologize for the long answer. Sounds great, let's do it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureNew feature or requestplanThis task is a linear part of the development planned for development.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions