Repository navigation
fix: CLI issues found testing the 0.4.0 release - #80
Merged
Merged
Conversation
The CLI waited for dotnet add package, npm and Tailwind to exit before reading their output. Once a process wrote more than a pipe buffer, both sides waited on each other, so shellui add all hung on .NET 8 and 9 apps while restoring Blazor-ApexCharts. ProcessRunner reads stdout and stderr while the process runs, and every call site uses it.
The tool ships net8.0 and net10.0 builds without a roll-forward policy, so a machine with only .NET 9 (or a future .NET 11) couldn't start it. RollForward=Major lets the net8.0 build run on newer runtimes.
With --installed the summary said "0 available", and with --available "0 installed", because the counts skipped filtered rows. They are now counted before filtering.
Tailwind 4 doesn't rewrite app.css when its output is unchanged, so after editing a component without new classes app.css kept an old timestamp and doctor said to run dotnet build even right after a build. The build targets now touch app.css after Tailwind runs. update replaces the targets file written by 0.4.0-alpha.2 and alpha.3 when it hasn't been edited.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Merged
Shewart
added a commit
that referenced
this pull request
Oct 30, 2026
Release notes and version references for 0.4.0, the 0.4 stable release. It fixes a hang in `shellui add` on .NET 8 and 9 apps that this release's smoke test found, and the 0.4.0 notes describe those fixes. **In this release** (on main, plus #80) - #76: PromptSuggestions, Reasoning, ToolCall, Field, JsonViewer - #77: a real resizable panel group (`ResizablePanelGroup` / `Panel` / `Handle`) - #78: `shellui migrate` - #74: .NET 8 support, `shellui add all`, `shellui doctor`, `SonnerService.Clear`, destructive context menu items, safelist fix - the whole 0.4 alpha line (alpha.1 to alpha.3), summed up for people upgrading from 0.3.6 - #80: `add` no longer hangs on .NET 8/9, the CLI rolls forward to newer runtimes, `doctor` stops calling a fresh `app.css` stale, `list` counts fixed Not in it: #79 (ShellCharts instead of ApexCharts) stays a draft for a later release. **This PR** - `Directory.Build.props`: empty suffix, so both packages build as `0.4.0` - README, VERSIONING_STRATEGY, CLI_INSTALLATION, CLI_SYNTAX, FAQ, QUICKSTART and the version fallbacks move to `0.4.0`. The latest stable was still listed as 0.3.5, so 0.3.6 is now the previous stable. Installs no longer need `--version`. - `docs/RELEASE_NOTES.md`: the 0.4.0 section. `scripts/extract-release-notes.sh 0.4.0` extracts it. **Release checks.** Packed 0.4.0, with #80, installed from a local folder into a private tool path, using a throwaway NuGet cache so nothing local shadows the published packages. - Release build: 0 warnings. 540 tests on net8.0 and net10.0 (542 with #80). - Every command in a fresh .NET 10 app: `init --yes`, `add all` (244 files), `list`, `remove`, `update`, `migrate --dry-run`, `theme apply`, `theme update`, `doctor`. Builds 0/0. - `init` and `add all` in fresh .NET 8 and .NET 9 apps build 0/0 and `doctor` is clean. Before #80, `add all` hung on both. - All 98 direct targets together, including the `dashboard-*` and `auth-*` blocks, in `my-app` (.NET 10): 0/0, `doctor` clean. - Upgrade from the published 0.4.0-alpha.3: - An app with a page using the old APIs builds on alpha.3. - 0.4.0 `update` rewrites 55 components and replaces the targets file, and the app builds 0/0. - `migrate` rewrites the page (DatePicker, TimePicker, Pagination), it builds 0/0, and `doctor` is clean. - CLI templates in a browser: - suggestion chips; Reasoning folds to "Thought for 2 seconds"; Field shows the EditForm error; JSON tree folds - Resizable drags from 30/70 to 55/45 - no console errors - Packed `ShellUI.Components` in a .NET 8 app with `shellui-all.css`, in light and dark mode: - the new components render; the resizable drag and suggestion chips work - Dialog focus trap: Tab stays inside, Escape closes and returns focus - `shellui.js` loads through the package's JS initializer, with no console errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by smoke-testing the packed 0.4.0 CLI and package in fresh apps before the release. Merge this before the 0.4.0 release PR.
addhung on .NET 8 and 9 apps (blocker). The CLI waited fordotnet add package, npm and Tailwind to exit before reading their output. Once a process wrote more than a pipe buffer, both sides waited forever.shellui add allstuck on restoring Blazor-ApexCharts in fresh .NET 8 and .NET 9 apps (.NET 10's output happened to be smaller). The newProcessRunnerreads both streams while the process runs, and all five call sites use it.RollForward=Majorlets the net8.0 build run on 9 and later. I checked by running it on the 9.0.12 runtime.list --installedsaid "0 available" (and--availablesaid "0 installed"). Counts are now taken before filtering.doctorcalled a freshapp.cssstale. Tailwind 4 skips writing unchanged output, so after any edit without new classesdoctorkept saying "Run dotnet build", even right after a build. The build targets now touchapp.cssafter Tailwind runs.updatereplaces the targets file from 0.4.0-alpha.2/alpha.3 if it wasn't edited, with a new fixture test.Tests: 542 passing on net8.0 and net10.0, 0 warnings. Added a test with about 100 KB of output on both streams, which would hang with the old pattern.
Rechecked with the repacked CLI:
add alltakes about 6 s and adds the three NuGet packages, builds 0/0,doctorcleanupdatereplaces the targets file, builds, anddoctoris clean after editing a page and rebuilding