Skip to content

Bug in use of rooms variable / access control to bot #8

Description

@chrisfahr

Hi,
there is an issue with your usage of the rooms variable.
In matrix_bot_api.py line 43 (else branch) you try to use it like an array of room objects.
This fails in line 46 when you try to assign handlers.
In the other branch you store (string) ids in it. Then again in line 71 you store objects.
This prevents one from using rooms in the constructor to limit access to the bot.

Activity

  1. shawnanastasio commented on Feb 28, 2018

    @shawnanastasio
    Owner

    Good catch. I suppose I'll update all branches to treat them as an array of string room ids, unless you think room objects would be better?

  2. chrisfahr commented on Mar 16, 2018

    @chrisfahr
    Author

    I think using strings is fine.
    Otherwise an user of the libary would have to call the underlying API to get the room objects,
    which kind of contradicts the use case that he has in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions