Repository navigation
make ModalProvider generic and dependency injectable and add tests - #69
Merged
Merged
Conversation
technojak
reviewed
Sep 7, 2021
technojak
approved these changes
Sep 7, 2021
technojak
left a comment
technojak
left a comment
Contributor
There was a problem hiding this comment.
lgtm. Curious if we should always capitalize component names
0xdef1cafe
force-pushed
the
modal-provider-tests
branch
from
September 7, 2021 22:23
804b5b3 to
2dda4fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notice
Before submitting a pull request, please make sure you have answered the following:
Pull Request Type
Issue (if applicable)
closes #46
Description
Please describe your changes
Testing
Please outline all testing steps
yarnto install new depsScreenshots (if applicable)