fix(thorchain): recover indexed transactions missing from direct lookup - #1290
Closed
0xApotheosis wants to merge 1 commit into
Closed
0xApotheosis wants to merge 1 commit into
0xApotheosis wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
Upstream bug which has been fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THORChain can return a transaction in account history while
/api/v1/tx/{txid}fails with HTTP 500: the upstream/txlookup says it is missing, but/tx_searchon the same provider still returns the complete signed transaction. For example, this affectsD4C2B478C69D020386D027CB2205CFCAE60D1BD791E93E31ACDAE8ACCB32AA9F.Fall back to a one-result exact-hash search only for the specific transaction-not-found RPC error and a valid 32-byte hash. Accept the result only when both its reported hash and the hash of its signed bytes match the requested transaction. Other upstream failures retain their existing behavior. Also preserve the decoding error instead of dereferencing a nil RPC error on malformed success responses.
Validation: live read-only checks recovered both audited missing transactions through exact-hash search, verified their signed-byte hashes, fetched their blocks, and confirmed account history formats the same transactions. An unknown hash returned no search results.
git diff --checkpasses. Local tests, Go builds/vet, and lint were not run perCLAUDE.md; CI provides build/lint validation.This addresses the THORChain lookup failure. The separately observed Arbitrum/Moralis miss is not changed here.