Repository navigation
fix(users): isolate profiles with device credentials - #68
Draft
0xApotheosis wants to merge 1 commit into
Draft
0xApotheosis wants to merge 1 commit into
0xApotheosis wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wallet addresses could retrieve another device's profile. Uses device-key authentication, session-scoped operations and one-use push delivery proofs. Internal administration requires the service key.
Apply shared auth/quota migrations once and test/release with microservices #69, web #12742 and mobile #165/#166.
Verification
Use two browser profiles with the same wallet: expect separate IDs, persistence on reload and no login signature. A's token must not access B; anonymous internal routes should return 401. Across two replicas, redeem one challenge concurrently: only one session may be issued. Reject wrong/expired/replayed push proofs and verify real-device registration.
Mocked checks passed; database and device QA remain outstanding.