Skip to content

fix: Move internal-only time package under internal (#62) - #121

Merged
shamaton merged 1 commit into
mainfrom
fix/issue-62
Sep 13, 2026
Merged

fix: Move internal-only time package under internal (#62)#121
shamaton merged 1 commit into
mainfrom
fix/issue-62

Conversation

@shamaton

@shamaton shamaton commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Move the  v3/time  package to  internal/time  to make clear it's a non-public implementation detail
  • Previously public  SetDecodedAsLocal  remains reachable via existing  msgpack.SetDecodedTimeAsUTC/Local 

Background / Motivation

  •  github.com/shamaton/msgpack/v3/time  was only used internally for timestamp ext encode/decode but had accidentally been exposed as a public package
  • Code search and pkg.go.dev checks found no external importers

Changes

  • Move files under  time/  to  internal/time/ 
  • Update import paths from  v3/time  to  v3/internal/time  across the codebase

Notes

@github-actions github-actions Bot added the type: bug Confirmed or likely defect label Sep 7, 2026
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.91%. Comparing base (da1826f) to head (de19ef3).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          74       74           
  Lines        7017     7017           
=======================================
  Hits         6520     6520           
  Misses        311      311           
  Partials      186      186           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shamaton
shamaton marked this pull request as ready for review September 13, 2026 00:30
@shamaton
shamaton merged commit d2d3873 into main Sep 13, 2026
27 checks passed
@shamaton
shamaton deleted the fix/issue-62 branch September 13, 2026 00:31
@github-actions github-actions Bot mentioned this pull request Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Confirmed or likely defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant