feat(dialog): forward overlay props from content#11217
Open
chahatkesh wants to merge 1 commit into
Open
Conversation
Contributor
|
@chahatkesh is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
chahatkesh
force-pushed
the
feat/base-dialog-overlay-props-11214
branch
from
July 18, 2026 15:34
0f7d1c5 to
204ee02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an
overlayPropsescape hatch toDialogContentandAlertDialogContentin the current Base UI and Radix registry sources.Why
Base UI intentionally omits backdrops for nested dialogs. Its
BackdropsupportsforceRender, but the shadcn convenience content components hardcoded their overlays, so consumers could not reach that prop without recomposing the portal and content.Before this change, passing
overlayPropsleaked the unknown prop to the popup DOM node and a nested dialog still rendered only one backdrop. After the change,overlayProps={{ forceRender: true }}renders the nested backdrop while preserving Base UI's default behavior when the prop is omitted.Changes
overlayPropsfrom Base UI Dialog and AlertDialog content to their overlaysVerification
pnpm exec vitest run apps/v4/registry/dialog.test.tsx(2 passed)NODE_OPTIONS=--max-old-space-size=4096 pnpm --filter=v4 typecheckpnpm --filter=v4 exec eslint registry/dialog.test.tsx registry/bases/base/ui/dialog.tsx registry/bases/base/ui/alert-dialog.tsx registry/bases/radix/ui/dialog.tsx registry/bases/radix/ui/alert-dialog.tsxpnpm exec prettier --checkon all touched filespnpm --filter=v4 registry:buildpnpm --filter=v4 postinstallReviewer notes
new-york-v4/deprecated registries for overlay styling and also includes app bootstrap changes. This PR targets the current Base/Radix source registries, covers AlertDialog, and validates Base UIforceRenderwith tests and docs.Closes #11214