fix(deps): pin dependency versions in Cargo.toml - #534
Conversation
|
thanks for contributing |
|
What is the motivation here? This is an unusual practice. |
|
to make sure that dependency requirements don't change between patch versions it seems that's what happened to technically 0.7 would have sufficed, but it seemed a version requiring rustc 1.86+ was published as a patch or something along those lines, so after the 0.7 download (which required 1.80 at publish time) some dep updated it's version of |
|
I don't think it's it's a good idea to use exact version pinning like this in a library crate, because any crate that includes smallvec anywhere in its dependency tree will no longer be able to independently upgrade (or downgrade) any crate that smallvec depends upon. |
|
Given how common it is for other projects to rely on serde_core and bytes, I think we should revert this change. It's going to confuse and annoy other projects. |
Summary
Cargo.tomlto their exact versions fromCargo.lock.Problem
Cargo.tomluses loose dependency versions, which can allow automatic patch updates and cause unexpected issues.Solution
=x.y.zversions matchingCargo.lock.Related
Closes #532