This repository was archived by the owner on Jul 3, 2026. It is now read-only.
Repository navigation
feat(views): add custom Linear views as sub-tab bar #56
Open
serabi
wants to merge
1
commit into
main
Choose a base branch
from
feat/custom-views
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom view issues are truncated at 50 items due to missing pagination.
GetCustomViewIssuesreturnsPageInfowithhasNextPageandendCursor, but this code discards the pagination info and never fetches subsequent pages. Users with more than 50 issues in a custom view will see an incomplete list.The existing issue fetching methods also lack pagination, so this may be an accepted limitation. However, custom views often contain curated issue sets that could exceed 50 items.
Consider adding pagination loop or documenting the limitation
If pagination is needed:
if m.activeViewIdx > 0 && m.activeViewIdx-1 < len(m.customViews) { viewID := m.customViews[m.activeViewIdx-1].ID - issues, _, err := client.GetCustomViewIssues(viewID, "") - return issuesLoadedMsg{issues: issues, err: err} + var allIssues []Issue + var after string + for { + issues, pageInfo, err := client.GetCustomViewIssues(viewID, after) + if err != nil { + return issuesLoadedMsg{err: err} + } + allIssues = append(allIssues, issues...) + if !pageInfo.HasNextPage { + break + } + after = pageInfo.EndCursor + } + return issuesLoadedMsg{issues: allIssues} }📝 Committable suggestion
🤖 Prompt for AI Agents