docs: fix four links to test files that moved in 2021 - #1133
Open
melbinjp wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four links in the docs point at test files that moved in
1dcc378(2021-12-14, "test: split up unit and integ tests"). Nothing else is touched.CONTRIBUTING.md:76test/test_sendgrid.pytest/unit/test_sendgrid.pyTROUBLESHOOTING.md:127test/test_eventwebhook.pytest/unit/test_eventwebhook.pysendgrid/helpers/inbound/README.md:130test/test_config.pytest/unit/test_config.pysendgrid/helpers/inbound/README.md:131test/test_parse.pytest/unit/test_parse.pyThree of those are plain renames. The
CONTRIBUTING.mdone is not, so here is the reasoning in full.1dcc378moved the original file totest/integ/test_sendgrid.py(R100, content unchanged), and it is the onlytest_sendgrid.pythat commit touched. A second one appeared later attest/unit/test_sendgrid.py, added byb5afcca(2023-11-24) with the GDPR region work, and it holds unit tests of the client host. The CONTRIBUTING sentence asks the reader to add unit tests, so it points there rather than at the file git paired the rename with. Say the word if you would rather it named both.CONTRIBUTING.mdis the file a first-time contributor is told to read, and its link to the test they are asked to edit has been a 404 for a little under five years.