Repository navigation
fix: upload reports only to app.secfoo.com with a confirmed ingest key - #104
Merged
Merged
Conversation
A configured portal URL or a view key could send the full report off the machine before the portal accepted the key. Sync now stays on https://app.secfoo.com and posts the report only after whoami confirms an ingest key. Scans, CVE enrichment, GitLab and Bitbucket clones, custom skills, and the dashboard bind address are unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+109
to
+110
| f'api_key = "{_toml_escape(api_key)}"\n' | ||
| f'portal_url = "{_toml_escape(portal_url)}"\n', |
| url = _memory_origin(config.url) | ||
| path.write_text( | ||
| f'api_key = "{_toml_escape(config.api_key)}"\nurl = "{_toml_escape(config.url)}"\n', | ||
| f'api_key = "{_toml_escape(config.api_key)}"\nurl = "{_toml_escape(url)}"\n', |
|
|
||
| from fastapi import FastAPI | ||
| from fastapi.staticfiles import StaticFiles | ||
| from starlette.responses import PlainTextResponse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sfc_ingest_...). A view key, a random string, or another host never receives the report.secfoo serve --host 0.0.0.0, and a self-hosted https memory URL behave as before.Test plan
secfoo cloud loginwith an ingest key still saves, andsecfoo cloud syncuploads the runsecfoo serve --host 0.0.0.0 --port 8787still startsMade with Cursor