dateutils.hours() gives wrong answer #57

Activity

1. LadderOperator commented on Feb 14, 2022

   

   LadderOperator

   on Feb 14, 2022

   Last edited by LadderOperator

   Author

   More actions

   I think this part leads to the problem:

    def datediff(self, start, end, unit='S'):
           ...
           elif unit == 'H':
               delta_days = (dt_end - dt_start).days
               if delta_days == 0:
                   return dt_end.hour - dt_start.hour
               return delta_days * 24 + (dt_end.hour - dt_start.hour)
          ...

   delta_days == 0 means less than 24 hours. To check if they are the same day, something like start.day == end.day should be used instead. Similar mistake occurs when delta_days not equals to 0.

   Since dateutils is implimented using datetime, this part can be improved:

   td = dt_end - dt_start
   delta = td.days * 24 + td.seconds / 3600
2. LadderOperator commented on Feb 14, 2022

   

   LadderOperator

   on Feb 14, 2022

   Author

   More actions

   OK, I think the datediff() (not only the hours()) function needs more check. Using more timedelta.days and timedelta.seconds could help making the code more clear to avoid bugs.