Conversation
nex3
self-requested a review
March 27, 2023 20:46
Contributor
|
Can you enable the corresponding JS API tests for this? |
Contributor
Author
|
@nex3 Regression test added. Test is passing here, but not passing in the spec repo as it looks like spec repo does not have support of cloning linked PR for embedded host. |
Contributor
|
Yeah, tests in the spec repo that add tests for the JS API should add "[skip sass-embedded]" to their description to avoid running tests against the base version. |
nex3
approved these changes
Apr 5, 2023
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Apr 5, 2023
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Apr 6, 2023
jgerigmeyer
added a commit
to oddbird/dart-sass
that referenced
this pull request
Apr 6, 2023
* main: Add a changelog entry for sass/embedded-host-node#212 (sass#1928)
This was referenced Apr 28, 2023
This was referenced Apr 29, 2023
This was referenced Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue here is that currently
process.cwd()is added inpluginThis, causing it to be missing in actualloadPaths.This PR modifies the logic to add
process.cwd()inadjustOptionsso that it affect actualloadPaths.sass.compile(),sassEmbedded.renderSync()andsassEmbedded.compile()methods, but not withsass.renderSync()method dart-sass#1920sass/sass-spec#1893