You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note on the red test (20.x) / test (22.x) jobs: the failures are in packages/harness (subsession-coordinator.test.ts — awaiting-ready vs reserved), which this PR does not touch.
Diff is limited to @sapiom/core header helpers omitting undefined values (+ regression tests). Happy to rebase once the harness flake/regression on main is sorted, or to split/re-run if maintainers prefer.
Rebased onto latest main to clear the unrelated subsession-coordinator harness failures (those tests are green on current main). Core change unchanged: omit undefined headers.
Follow-up: rebase push is blocked from this token (workflow OAuth scope — updating the branch to current main would introduce .github/workflows/* changes).
The failing harness tests (subsession-coordinator readiness states) are unrelated to this PR’s diff (packages/core header omission only). Those tests are green on current main (e.g. Test workflow on fd9ec19). Please rebase-from-main on the GitHub UI / merge with update-branch if CI needs a fresh run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area: sdkChanges to SDK core or analyticscontribution: incompleteRequired pull request information is incomplete or ambiguouscontributor: externalPull request author does not have write, maintain, or admin access to sapiom-jsneeds-triageAwaiting maintainer review and classificationreview: manualExternal pull request requires maintainer review before automationsize: smallReview size is at most 100 changed lines
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setHeaderandremoveHeaderTests
pnpm --filter @sapiom/core test --runInBandpnpm --filter @sapiom/core typecheckpnpm --filter @sapiom/core lint(passes with 3 existing warnings)pnpm exec prettier --check packages/core/src/utils/utils.ts packages/core/src/utils/utils.test.tsFixes #625